[lexical-playground] Refactor: Image component rerenders on every editor update #7233
Conversation
jvithlani
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @jvithlani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@jvithlani this looks good. Could you sign the CLA? |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Description
Currently the image element in editor sheet rerenders on every character modified in the editor, which leads to typing speed latency when more number of images are present in the editor. Updated the code to ensure its only rerendered when needed
Before
Screen.Recording.2025-02-22.at.3.03.15.PM.mov
After
Screen.Recording.2025-02-22.at.3.04.43.PM.mov
Insert relevant screenshots/recordings/automated-tests